[SPARK-36058][K8S][TESTS][FOLLOWUP] Fix error message to include exception correctly #35829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
commented
Mar 13, 2022
| s"Error fetching log (pod is likely not ready) $e" | ||
| } | ||
| logInfo(s"\nBEGIN executor (${execPod.getMetadata.getName}) POD log:\n" + | ||
| podLog) |
Member
Author
There was a problem hiding this comment.
I updated this because the indentation is wrong.
wangyum
approved these changes
Mar 13, 2022
huaxingao
approved these changes
Mar 13, 2022
Member
|
Merged to master. |
Member
Author
|
Thank you, @wangyum , @huaxingao , @Yikun . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to fix error message to include the exception because #33508 missed the string interpolation prefix,
s".spark/resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala
Line 110 in c032928
Why are the changes needed?
To show the intended message.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manual review.